Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix KeyboardAvoidingView infinite updates on android #48171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Dec 8, 2024

Summary:

fix a regression from 1cea8e8 that would fix #47140 and potentially #47926 (comment)

the keyboardDidHide sent an incorrect screenY value. before 1cea8e8, the screenY is the size including system bar. after that change, it does not, because getWindowVisibleDisplayFrame() does not include system bar size.

this pr tries to align the screenX and screenY values as the keyboardDidShow event. we should use the same logic between show and hide.

Changelog:

[ANDROID] [FIXED] - Fix KeyboardAvoidingView infinite updates on Android

Test Plan:

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner labels Dec 8, 2024
@Kudo Kudo marked this pull request as ready for review December 8, 2024 09:25
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 8, 2024
@paul-votebud
Copy link

I'm having strange issue and this fix may be related to that. Why is this PR still not reviewed? @Kudo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyboardAvoidingView with translucent status bar leaves space at the bottom of the screen on Android
3 participants