Add queueMicrotask method to JSI #43235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54302536 |
rubennorte
force-pushed
the
export-D54302536
branch
from
487d04b to
bc3efd3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54302536 |
|
@rubennorte this opens the road for this? |
@efstathiosntonas yes! The plan is to enable the new event loop in the new RN architecture soon, which will unblock WeakRefs in Hermes. |
|
@rubennorte thanks for the update, so this is targeting exclusively on new arch? |
Yes, that's right. |
Summary: X-link: facebook/hermes#1331 Changelog: [internal] ## Context Microtasks are an important aspect of JavaScript and they will become increasingly important in the hosts where we're currently using JSI. For example, React Native is going to adopt an event loop processing model similar to the one on the Web, which means it would need the ability to schedule and execute microtasks in every iteration of the loop. See react-native-community/discussions-and-proposals#744 for details. JSI already has a method to execute all pending microtasks (`drainMicrotasks`) but without a method to schedule microtasks this is incomplete. We're currently testing microtasks with Hermes using an internal method to schedule microtasks (`HermesInternal.enqueueJob`) but we need a method in JSI so this also works in other runtimes like JSC and V8. ## Changes This adds the `queueMicrotask` to the Runtime API in JSI so we have symmetric API for microtasks and we can implement the necessary functionality. The expectation for JSI implementations is to queue microtasks from this method and from built-ins like Promises and async functions in the same queue, and not drain that queue until explicitly done via `drainMicrotasks` in JSI. This also modifies Hermes and JSC to provide stubs for those methods, and the actual implementation will be done in following diffs. Reviewed By: neildhar Differential Revision: D54302536
rubennorte
force-pushed
the
export-D54302536
branch
from
bc3efd3 to
c3e0b5e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54302536 |
|
This was committed in 036f47e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Context
Microtasks are an important aspect of JavaScript and they will become increasingly important in the hosts where we're currently using JSI.
For example, React Native is going to adopt an event loop processing model similar to the one on the Web, which means it would need the ability to schedule and execute microtasks in every iteration of the loop. See react-native-community/discussions-and-proposals#744 for details.
JSI already has a method to execute all pending microtasks (
drainMicrotasks) but without a method to schedule microtasks this is incomplete.We're currently testing microtasks with Hermes using an internal method to schedule microtasks (
HermesInternal.enqueueJob) but we need a method in JSI so this also works in other runtimes like JSC and V8.Changes
This adds the
queueMicrotaskto the Runtime API in JSI so we have symmetric API for microtasks and we can implement the necessary functionality.The expectation for JSI implementations is to queue microtasks from this method and from built-ins like Promises and async functions in the same queue, and not drain that queue until explicitly done via
drainMicrotasksin JSI.This also modifies Hermes and JSC to provide stubs for those methods, and the actual implementation will be done in following diffs.
Differential Revision: D54302536