flowified Libraries from Avik

facebook · Mar 25, 2015 · 95deed5 · 95deed5
1 parent 18b6d5c
commit 95deed5
Show file tree

Hide file tree

Showing 22 changed files with 238 additions and 99 deletions.
diff --git a/Libraries/Components/ActivityIndicatorIOS/ActivityIndicatorIOS.ios.js b/Libraries/Components/ActivityIndicatorIOS/ActivityIndicatorIOS.ios.js
@@ -7,6 +7,7 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *
  * @providesModule ActivityIndicatorIOS
+ * @flow
  */
 'use strict';
 
@@ -29,6 +30,12 @@ var SpinnerSize = keyMirror({
 
 var GRAY = '#999999';
 
+type DefaultProps = {
+  animating: boolean;
+  size: 'small' | 'large';
+  color: string;
+};
+
 var ActivityIndicatorIOS = React.createClass({
   mixins: [NativeMethodsMixin],
 
@@ -51,7 +58,7 @@ var ActivityIndicatorIOS = React.createClass({
     ]),
   },
 
-  getDefaultProps: function() {
+  getDefaultProps: function(): DefaultProps {
     return {
       animating: true,
       size: SpinnerSize.small,

diff --git a/Libraries/Components/DatePicker/DatePickerIOS.ios.js b/Libraries/Components/DatePicker/DatePickerIOS.ios.js
@@ -7,6 +7,7 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *
  * @providesModule DatePickerIOS
+ * @flow
  *
  * This is a controlled component version of RCTDatePickerIOS
  */
@@ -26,6 +27,12 @@ var merge = require('merge');
 
 var DATEPICKER = 'datepicker';
 
+type DefaultProps = {
+  mode: 'date' | 'time' | 'datetime';
+};
+
+type Event = Object;
+
 /**
  * Use `DatePickerIOS` to render a date/time picker (selector) on iOS.  This is
  * a controlled component, so you must hook in to the `onDateChange` callback
@@ -85,13 +92,13 @@ var DatePickerIOS = React.createClass({
     timeZoneOffsetInMinutes: PropTypes.number,
   },
 
-  getDefaultProps: function() {
+  getDefaultProps: function(): DefaultProps {
     return {
       mode: 'datetime',
     };
   },
 
-  _onChange: function(event) {
+  _onChange: function(event: Event) {
     var nativeTimeStamp = event.nativeEvent.timestamp;
     this.props.onDateChange && this.props.onDateChange(
       new Date(nativeTimeStamp)

diff --git a/Libraries/Components/MapView/MapView.js b/Libraries/Components/MapView/MapView.js
@@ -7,6 +7,7 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *
  * @providesModule MapView
+ * @flow
  */
 'use strict';
 
@@ -21,6 +22,8 @@ var deepDiffer = require('deepDiffer');
 var insetsDiffer = require('insetsDiffer');
 var merge = require('merge');
 
+type Event = Object;
+
 var MapView = React.createClass({
   mixins: [NativeMethodsMixin],
 
@@ -119,7 +122,7 @@ var MapView = React.createClass({
     onRegionChangeComplete: React.PropTypes.func,
   },
 
-  _onChange: function(event) {
+  _onChange: function(event: Event) {
     if (event.nativeEvent.continuous) {
       this.props.onRegionChange &&
         this.props.onRegionChange(event.nativeEvent.region);

diff --git a/Libraries/Components/Navigation/NavigatorIOS.ios.js b/Libraries/Components/Navigation/NavigatorIOS.ios.js
@@ -7,6 +7,7 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *
  * @providesModule NavigatorIOS
+ * @flow
  */
 'use strict';
 
@@ -59,7 +60,7 @@ var RCTNavigatorItem = createReactIOSNativeComponentClass({
 var NavigatorTransitionerIOS = React.createClass({
   requestSchedulingNavigation: function(cb) {
     RCTNavigatorManager.requestSchedulingJavaScriptNavigation(
-      this.getNodeHandle(),
+      (this: any).getNodeHandle(),
       logError,
       cb
     );
@@ -72,6 +73,29 @@ var NavigatorTransitionerIOS = React.createClass({
   },
 });
 
+type Route = {
+  component: Function;
+  title: string;
+  passProps: Object;
+  backButtonTitle: string;
+  rightButtonTitle: string;
+  onRightButtonPress: Function;
+  wrapperStyle: any;
+};
+
+type State = {
+  idStack: Array<number>;
+  routeStack: Array<Route>;
+  requestedTopOfStack: number;
+  observedTopOfStack: number;
+  progress: number;
+  fromIndex: number;
+  toIndex: number;
+  makingNavigatorRequest: boolean;
+  updatingAllIndicesAtOrBeyond: number;
+}
+
+type Event = Object;
 
 /**
  * Think of `<NavigatorIOS>` as simply a component that renders an
@@ -224,6 +248,8 @@ var NavigatorIOS = React.createClass({
 
   },
 
+  navigator: (undefined: ?Object),
+
   componentWillMount: function() {
     // Precompute a pack of callbacks that's frequently generated and passed to
     // instances.
@@ -240,7 +266,7 @@ var NavigatorIOS = React.createClass({
     };
   },
 
-  getInitialState: function() {
+  getInitialState: function(): State {
     return {
       idStack: [getuid()],
       routeStack: [this.props.initialRoute],
@@ -266,22 +292,32 @@ var NavigatorIOS = React.createClass({
     };
   },
 
-  _handleFocusRequest: function(item) {
+  _toFocusOnNavigationComplete: (undefined: any),
+
+  _handleFocusRequest: function(item: any) {
     if (this.state.makingNavigatorRequest) {
       this._toFocusOnNavigationComplete = item;
     } else {
       this._getFocusEmitter().emit('focus', item);
     }
   },
 
-  _getFocusEmitter: function() {
-    if (!this._focusEmitter) {
-      this._focusEmitter = new EventEmitter();
+  _focusEmitter: (undefined: ?EventEmitter),
+
+  _getFocusEmitter: function(): EventEmitter {
+    // Flow not yet tracking assignments to instance fields.
+    var focusEmitter = this._focusEmitter;
+    if (!focusEmitter) {
+      focusEmitter = new EventEmitter();
+      this._focusEmitter = focusEmitter;
     }
-    return this._focusEmitter;
+    return focusEmitter;
   },
 
-  getChildContext: function() {
+  getChildContext: function(): {
+    onFocusRequested: Function;
+    focusEmitter: EventEmitter;
+  } {
     return {
       onFocusRequested: this._handleFocusRequest,
       focusEmitter: this._getFocusEmitter(),
@@ -293,13 +329,13 @@ var NavigatorIOS = React.createClass({
     focusEmitter: React.PropTypes.instanceOf(EventEmitter),
   },
 
-  _tryLockNavigator: function(cb) {
+  _tryLockNavigator: function(cb: () => void) {
     this.refs[TRANSITIONER_REF].requestSchedulingNavigation(
       (acquiredLock) => acquiredLock && cb()
     );
   },
 
-  _handleNavigatorStackChanged: function(e) {
+  _handleNavigatorStackChanged: function(e: Event) {
     var newObservedTopOfStack = e.nativeEvent.stackLength - 1;
     invariant(
       newObservedTopOfStack <= this.state.requestedTopOfStack,
@@ -352,7 +388,7 @@ var NavigatorIOS = React.createClass({
     });
   },
 
-  push: function(route) {
+  push: function(route: Route) {
     invariant(!!route, 'Must supply route to push');
     // Make sure all previous requests are caught up first. Otherwise reject.
     if (this.state.requestedTopOfStack === this.state.observedTopOfStack) {
@@ -372,7 +408,7 @@ var NavigatorIOS = React.createClass({
     }
   },
 
-  popN: function(n) {
+  popN: function(n: number) {
     if (n === 0) {
       return;
     }
@@ -406,7 +442,7 @@ var NavigatorIOS = React.createClass({
    * `index` specifies the route in the stack that should be replaced.
    * If it's negative, it counts from the back.
    */
-  replaceAtIndex: function(route, index) {
+  replaceAtIndex: function(route: Route, index: number) {
     invariant(!!route, 'Must supply route to replace');
     if (index < 0) {
       index += this.state.routeStack.length;
@@ -434,22 +470,22 @@ var NavigatorIOS = React.createClass({
   /**
    * Replaces the top of the navigation stack.
    */
-  replace: function(route) {
+  replace: function(route: Route) {
     this.replaceAtIndex(route, -1);
   },
 
   /**
    * Replace the current route's parent.
    */
-  replacePrevious: function(route) {
+  replacePrevious: function(route: Route) {
     this.replaceAtIndex(route, -2);
   },
 
   popToTop: function() {
     this.popToRoute(this.state.routeStack[0]);
   },
 
-  popToRoute: function(route) {
+  popToRoute: function(route: Route) {
     var indexOfRoute = this.state.routeStack.indexOf(route);
     invariant(
       indexOfRoute !== -1,
@@ -459,7 +495,7 @@ var NavigatorIOS = React.createClass({
     this.popN(numToPop);
   },
 
-  replacePreviousAndPop: function(route) {
+  replacePreviousAndPop: function(route: Route) {
     // Make sure all previous requests are caught up first. Otherwise reject.
     if (this.state.requestedTopOfStack !== this.state.observedTopOfStack) {
       return;
@@ -476,7 +512,7 @@ var NavigatorIOS = React.createClass({
     });
   },
 
-  resetTo: function(route) {
+  resetTo: function(route: Route) {
     invariant(!!route, 'Must supply route to push');
     // Make sure all previous requests are caught up first. Otherwise reject.
     if (this.state.requestedTopOfStack !== this.state.observedTopOfStack) {
@@ -486,15 +522,15 @@ var NavigatorIOS = React.createClass({
     this.popToRoute(route);
   },
 
-  handleNavigationComplete: function(e) {
+  handleNavigationComplete: function(e: Event) {
     if (this._toFocusOnNavigationComplete) {
       this._getFocusEmitter().emit('focus', this._toFocusOnNavigationComplete);
       this._toFocusOnNavigationComplete = null;
     }
     this._handleNavigatorStackChanged(e);
   },
 
-  _routeToStackItem: function(route, i) {
+  _routeToStackItem: function(route: Route, i: number) {
     var Component = route.component;
     var shouldUpdateChild = this.state.updatingAllIndicesAtOrBeyond !== null &&
       this.state.updatingAllIndicesAtOrBeyond >= i;