Skip to content

Commit

Permalink
debug! instead of warn! on non-Python file in sourcedb
Browse files Browse the repository at this point in the history
Summary: The event of when sourcedb detects a non-Python file is not interesting enough to warrant a warning message (we know it happens very often in 3p targets). Downgrade the message to debug level to avoid spamming console logs.

Reviewed By: samwgoldman

Differential Revision: D67177209

fbshipit-source-id: 2233eb2477932f8dba9107c93d10dc71c735b81e
  • Loading branch information
grievejia authored and facebook-github-bot committed Dec 13, 2024
1 parent 0d722f6 commit 88a279b
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pyre2/pyre2/bin/module/source_db.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use std::path::PathBuf;
use anyhow::anyhow;
use anyhow::Context as _;
use starlark_map::small_map::SmallMap;
use tracing::warn;
use tracing::debug;
use vec1::Vec1;

use crate::error::style::ErrorStyle;
Expand Down Expand Up @@ -59,7 +59,8 @@ fn read_manifest_file_data(data: &[u8]) -> anyhow::Result<Vec<ManifestItem>> {
});
}
Err(error) => {
warn!("Cannot convert path to module name: {error:#}");
// This often happens for buckified 3rd-party targets
debug!("Cannot convert path to module name: {error:#}");
}
}
}
Expand Down

0 comments on commit 88a279b

Please sign in to comment.