Collect isESMImport and propagate through to ResolutionContext #1376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Correct
package.json#exports
andpackage.json#imports
support requires that we assert an"import"
or"require"
condition.From the Node.js (where this spec originated) docs:
Currently, we don't distinguish between import-ish and require-ish dependencies. This modifies
collectDependencies
to addisESMImport
to the collectedDependencyData
and dependency key (so that for exampleimport('foo')
andrequire('foo')
in the same file are considered distinct edges with potentially different resolutions).Test Plan:
Modified unit tests
Tested E2E further down the stack
Changelog: [Internal]