Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OSS autotools build has been nonfunctional for about a year. While #449 would be a better long-term approach to fixing the build since it would also bring it in sync with other Meta OSS projects and enable testing in CI, fixing the existing build until there's movement on that front would at least provide a signal on whether the OSS version is buildable at all.
So:
MCROUTER_OSS_BUILD
to mark OSS-specific conditional compilation blocks. This could probably replace the existingLIBMC_FBTRACE_DISABLE
andDISABLE_COMPRESSION
defines too, as long as those aren't used outside of the OSS build.HostInfoLocation::hostUniqueKey
(used since 85facb9).FB_LOG_EVERY_MS
glog wrapper over a Meta-specific include (used since 6c2142a).Fixes #453, fixes #444, fixes #447 etc.