Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autotools build #457

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mszabo-wikia
Copy link
Contributor

@mszabo-wikia mszabo-wikia commented Dec 11, 2024

The OSS autotools build has been nonfunctional for about a year. While #449 would be a better long-term approach to fixing the build since it would also bring it in sync with other Meta OSS projects and enable testing in CI, fixing the existing build until there's movement on that front would at least provide a signal on whether the OSS version is buildable at all.

So:

  • Introduce new Ubuntu 24.04 build files and use them in CI. I'll remove build files, Dockerfiles etc. for ancient Ubuntu and CentOS versions in a followup PR.
  • Pin fmtlib to 11.0.2, like fbcode_builder does, and skip building its test suite to not waste time.
  • Use Ninja to generate and build CMake-based dependencies.
  • Use googletest, gmock and zstd as packaged by Ubuntu rather than building their older versions from source.
  • Introduce and use a new define MCROUTER_OSS_BUILD to mark OSS-specific conditional compilation blocks. This could probably replace the existing LIBMC_FBTRACE_DISABLE and DISABLE_COMPRESSION defines too, as long as those aren't used outside of the OSS build.
  • Fix OSS build failures that have gone undetected due to CI being broken:
    • Add a shim for the SR-specific method HostInfoLocation::hostUniqueKey (used since 85facb9).
    • Use folly's FB_LOG_EVERY_MS glog wrapper over a Meta-specific include (used since 6c2142a).
    • Disable client identity propagation in the OSS build since it relies on Meta-specific code (used since 2f32271).

Fixes #453, fixes #444, fixes #447 etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants