[lexical-table] Fix: Delete table row in merge cells #6922
Merged
+463
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamvinayvk
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
etrepum
reviewed
Dec 8, 2024
|
I don't think this fix is sufficient Take for example this PR playground url, if you delete the row from the cell marked 'x' then it will deform the table delete-row-bug.mov |
|
@etrepum I have handled the above case and also added two tests for the row deletion previous-merged-cell.mp4 |
etrepum
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes in this pull request
When deleting the table row for the merged cells the calculation of the actual row span for the cells was incorrect due to which extra columns were being created. Fixed the rowSpan calculation for the merged cells by taking the minimum value of the
anchorCell.__rowSpanand the difference of overflow of top rows and current cellrowSpan.Closes #5854
Test plan
Before
Insert relevant screenshots/recordings/automated-tests
Recording.2024-12-09.040342.1.mp4
After
Insert relevant screenshots/recordings/automated-tests
Recording.2024-12-09.040633.1.mp4