[lexical-table] Bug Fix: Resolve table selection issue when the mouse crosses over a portal

[etrepum]

Description

When using table selection by mouse movement, if the mouse crosses over an element that is outside of the document, it ends up creating a native selection that messes up the intended table selection.

Unfortunately when researching this bug I accidentally learned how much of a tangled un-idiomatic mess this plugin is and I couldn't figure out how to fix it without a larger refactoring. The primary anti-patterns are basically nested and cascading updates.

For whatever historical reason, lexical uses the most error-prone design imaginable for nested updates, so they should be avoided at all cost (surprisingly, dispatchCommand avoids this issue by working in the manner that nested updates should have been implemented). TableObserver's methods are primarily used inside updates, but because sometimes they are called from mouse events they all have an explicit editor.update which is a mistake. I've renamed them all to $methods to be explicit on their dependencies and how to use them.

By doing this in a way that actually makes sense for Lexical, we will probably fix some bugs we don't know about yet, remove the cascading updates, and remove the setTimeout nonsense that was used to work around the nested and cascading updates.

This is not a complete refactor, just enough to get things working. I'm sure more logic could be cleaned up here, especially regarding nested tables.

Closes #6820
Closes #6861 (the code from that PR is also here)

Test plan

Before

table-action-cell-button-select.mov

After

table-action-cell-button-hide.mov

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 24, 2024 1:02am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 24, 2024 1:02am

[github-actions]

size-limit report 📦

Path	Size
lexical - cjs	30.95 KB (0%)
lexical - esm	30.76 KB (0%)
@lexical/rich-text - cjs	39.62 KB (0%)
@lexical/rich-text - esm	32.66 KB (0%)
@lexical/plain-text - cjs	38.21 KB (0%)
@lexical/plain-text - esm	29.9 KB (0%)
@lexical/react - cjs	41.32 KB (0%)
@lexical/react - esm	34.06 KB (0%)

[ivailop7]

Fantastic work! Really well done, Bob!