Workaround non-null parent requirement of StubBase #513
Conversation
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
I really appreciate the code you put here, but I wonder if we need to update the Kotlin version.
My worry is that if we put Kotlin 2.0.20 here then maybe people trying to use ktfmt with an earlier version of Kotlin will have issues integrating with it.
I understand that running ktfmt from a binary should not be problem, but there are instances where it is used as a code integration, like in LSPs or running it as a deamon.
jsjeon
force-pushed
the
upgrade-kotlin-2.0.20
branch
from
8990524
to
c2ed63d
Compare
jsjeon
changed the title
|
nit: would you mind adding the change to the |
I assumed it would be under Unreleased / fixed ? |
jsjeon
force-pushed
the
upgrade-kotlin-2.0.20
branch
from
c2ed63d
to
506f549
Compare
|
@hick209 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Let me know what I need to do regarding Internal Linter error / test failures. |
|
@jsjeon it's just a minor thing, don't worry about it, I can take care of it 🙂 |
|
Hi, Would it be possible for you to create a release with this workaround? I encountered projects where it is now not possible to update the Kotlin version and have proper formatting checks, since this issue is also propagated in the ktfmt-gralde plugin. |
|
Hi, the integration via Spotless Gradle plugin is also affected. |
|
Released on https://github.com/facebook/ktfmt/releases/v0.53 |
No description provided.