Skip to content

Commit

Permalink
Removed remaining dropbox style references
Browse files Browse the repository at this point in the history
Summary:
Since this was removed on v0.51, it no longer makes sense to have those around.
Ideally this should have happened on [this commit](4a393bb).

Reviewed By: cortinico

Differential Revision: D58781951

fbshipit-source-id: 9a9d1efcaf554781acc5cacd09bdbd520ee96bfd
  • Loading branch information
Nivaldo Bondança authored and facebook-github-bot committed Jun 19, 2024
1 parent f31448e commit 713ed08
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 103 deletions.
8 changes: 4 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).

### Changed
- Preserves blank spaces between when clauses (https://github.com/facebook/ktfmt/issues/342)
- Named the default style as `Formatter.META_FORMAT` / `--meta-style`
- `FormattingOptions` constructor parameters order was changed
- Named the default style as `Formatter.META_FORMAT` / `--meta-style` (https://github.com/facebook/ktfmt/commit/96a7b1e2539eef43044f676f60400d22265fd115)
- `FormattingOptions` constructor parameters order was changed (https://github.com/facebook/ktfmt/commit/520706e6d010d48619781d7113e5b1522f07a2ba)

### Fixed
- Compilation issues with online formatter (https://github.com/facebook/ktfmt/commit/8605080cb0aadb7eaba20f3b469d6ddafe32c941)
- Removing valid semicolons (https://github.com/facebook/ktfmt/issues/459)
- Incorrect detection of unused `assign` import (https://github.com/facebook/ktfmt/issues/411)

### Removed
- **Deleted `Formatter.DROPBOX_FORMAT` / `--dropbox-style` (BREAKING CHANGE)**
- Deleted `FormattingOptions.Style` enum
- **Deleted `Formatter.DROPBOX_FORMAT` / `--dropbox-style` (BREAKING CHANGE)** (https://github.com/facebook/ktfmt/commit/4a393bb8c1156a4a0fd1ab736c02ca8dbd39a969)
- Deleted `FormattingOptions.Style` enum (https://github.com/facebook/ktfmt/commit/7edeff14c3738427e53427eb6e39675dc30d1d05)
6 changes: 0 additions & 6 deletions core/src/test/java/com/facebook/ktfmt/cli/ParsedArgsTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,6 @@ class ParsedArgsTest {
assertThat(parsed.formattingOptions).isEqualTo(Formatter.META_FORMAT)
}

@Test
fun `parseOptions recognizes --dropbox-style`() {
val parsed = assertSucceeds(ParsedArgs.parseOptions(arrayOf("--kotlinlang-style", "foo.kt")))
assertThat(parsed.formattingOptions).isEqualTo(Formatter.KOTLINLANG_FORMAT)
}

@Test
fun `parseOptions recognizes --google-style`() {
val parsed = assertSucceeds(ParsedArgs.parseOptions(arrayOf("--google-style", "foo.kt")))
Expand Down
93 changes: 0 additions & 93 deletions docs/editorconfig/.editorconfig-dropbox

This file was deleted.

0 comments on commit 713ed08

Please sign in to comment.