This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
Replace root view resolver with curtains #5572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56015851 |
lblasa
pushed a commit
to lblasa/flipper
that referenced
this pull request
Apr 15, 2024
Summary: Curtains allows a common entrypoint into accessing the root views, this means multiple tools can access it without clobbering each others observable array list it also means we can get rid of some nasty reflection code that we don't maintain as well as curtains Differential Revision: D56015851
lblasa
force-pushed
the
export-D56015851
branch
from
302a9a9 to
c776cab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56015851 |
lblasa
pushed a commit
to lblasa/flipper
that referenced
this pull request
Apr 15, 2024
Summary: Curtains allows a common entrypoint into accessing the root views, this means multiple tools can access it without clobbering each others observable array list it also means we can get rid of some nasty reflection code that we don't maintain as well as curtains Differential Revision: D56015851
lblasa
force-pushed
the
export-D56015851
branch
from
c776cab to
6ee7a19
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56015851 |
Pull Request Test Coverage Report for Build 8691255229Details
💛 - Coveralls |
Summary: Curtains allows a common entrypoint into accessing the root views, this means multiple tools can access it without clobbering each others observable array list it also means we can get rid of some nasty reflection code that we don't maintain as well as curtains Differential Revision: D56015851
lblasa
force-pushed
the
export-D56015851
branch
from
6ee7a19 to
40b705c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56015851 |
|
This pull request has been merged in 30dde7a. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Curtains allows a common entrypoint into accessing the root views, this means multiple tools can access it without clobbering each others observable array list
it also means we can get rid of some nasty reflection code that we don't maintain as well as curtains
Differential Revision: D56015851