This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unlike the other
DatabaseDriver
protocol methods,-executeSQL:
wasn't passing theDatabaseDescriptor
object. The database driver implementation needs that context in order to know which database connection to use.This matches the Android DatabaseDriver interface:
flipper/android/src/main/java/com/facebook/flipper/plugins/databases/DatabaseDriver.java
Lines 52 to 53 in 9053a6c
I renamed this method to
-executeSQLWithDatabaseDescriptor:sql:
to match the convention used by the other methods.Changelog
In DatabaseDriver, rename -executeSQL: to executeSQLWithDatabaseDescriptor:sql: and pass the DatabaseDescriptor object.
Test Plan
Verified the
MockDatabaseDriver
implementation continues to work as before, and verified that theexecute
command now receives the DatabaseDescriptor (in a local project).