Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Commit

Permalink
Expose app bundle id
Browse files Browse the repository at this point in the history
Summary: It used to use the id, which is definitely not the app or bundle identifier. It gracefully handles old clients by using the previously used id if the app_id is not found.

Reviewed By: lblasa

Differential Revision: D56578429

fbshipit-source-id: e7a234cea1ca4a70b5840bca9a817b174390a3df
  • Loading branch information
antonk52 authored and facebook-github-bot committed May 8, 2024
1 parent e4c8c99 commit f58a91f
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions desktop/flipper-plugin/src/plugin/Plugin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ export interface PluginClient<
*/
readonly appId: string;

/**
* Identifier that uniquely identifies the application bundle
*/
readonly bundleId: string;

/**
* Registered name for the connected application
*/
Expand Down Expand Up @@ -195,6 +200,9 @@ export class SandyPluginInstance extends BasePluginInstance {
get appId() {
return realClient.id;
},
get bundleId() {
return realClient.query.app_id ?? 'unknown';
},
get appName() {
return realClient.query.app;
},
Expand Down

0 comments on commit f58a91f

Please sign in to comment.