This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make toBase64() helper function static
Summary: Context = I am creating a flipper plugin to track and show network requests in a waterfall display to help IG App developers for my intern project. Having completed the project on iOS, I am now bringing the plugin to Android This Diff = This diff makes the `toBase64()` helper function in `NetworkFlipperPlugin.java` static. This will allow me to use that function from within `IGNetworkingBehaviorFlipperPlugin.kt` without creating an instance of the `NetworkFlipperPlugin` class. To avoid a `accidental override: The following declarations have the same JVM signature (toBase64([B)Ljava/lang/String;):` error, this diff removes the `toBase64()` function in `PortalNetworkFlipperPlugin.kt` This error occurs because `PortalNetworkFlipperPlugin.kt` imports `NetworkFlipperPlugin`, so making the function `public` caused a conflict since both functions had the same name and parameters. Now, `PortalNetworkFlipperPlugin.kt` will use the `toBase64()` function defined in `NetworkFlipperPlugin` (they were identical, so this change won't impact the codebase in any way). Differential Revision: D59346952 fbshipit-source-id: 4990a06430864b5feda81a190a30e7776a721c1f
- Loading branch information