Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Commit

Permalink
Limit the impact of the connection notifications
Browse files Browse the repository at this point in the history
Summary:
These notifications can get a bit annoying and in the way.

They are now keyyed on app so multiple notifications from the same app do not pile up

They are now allowed to cover the nav bar. Better to cover this than cover the plugin content area

Added a limit also

Reviewed By: mweststrate

Differential Revision: D55250950

fbshipit-source-id: c04d2efc88fad4d4c9b7f8278d85c2e7facedb35
  • Loading branch information
Luke De Feo authored and facebook-github-bot committed Mar 28, 2024
1 parent 8d509f7 commit a57d5e3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion desktop/flipper-ui/src/app-connection-updates.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export const connectionUpdate = (
content += `\n ${update.detail}`;
}
message.open({
key: update.key,
key: update.app,
type: update.type === 'success-info' ? 'info' : update.type,
content,
className,
Expand Down
3 changes: 2 additions & 1 deletion desktop/flipper-ui/src/sandy-chrome/SandyApp.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ export function SandyApp() {
// Messages need to be pushed down to make sure they appear below
// the navigation bar which has a height of 68px.
message.config({
top: 68,
top: 10,
maxCount: 2,
});

useEffect(() => {
Expand Down

0 comments on commit a57d5e3

Please sign in to comment.