Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: highlight MDXProvider requirement for importing MDX into React pages. #9485

Closed
wants to merge 1 commit into from

Conversation

homotechsual
Copy link
Contributor

@homotechsual homotechsual commented Oct 31, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 31, 2023
Copy link

netlify bot commented Oct 31, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit a62ad69
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65416507d2f416000898ac65
😎 Deploy Preview https://deploy-preview-9485--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 82 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 50 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 64 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 59 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 49 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 83 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 83 🟢 100 🟢 100 🟢 90 🟠 89 Report

@homotechsual homotechsual changed the title Highlight MDXProvider requirement for importing MDX into React pages. docs: highlight MDXProvider requirement for importing MDX into React pages. Nov 1, 2023
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary because (a) the linked section is above this (b) this particular section doesn't even demonstrate importing into React pages (although you could infer based on your knowledge). I'll let @slorber decide.

@slorber
Copy link
Collaborator

slorber commented Nov 26, 2023

i'm not a fan, the section is about importing one markdown file into another, which is not really related to mdxprovider

@slorber slorber closed this Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants