Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test coverage; properly test core client APIs #6905

Merged
merged 2 commits into from
Mar 12, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

We are finally clear of jest.mock usage! Should help with migration to ESM. #6520

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 12, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 12, 2022
@netlify
Copy link

netlify bot commented Mar 12, 2022

✔️ [V2]

🔨 Explore the source changes: 7583708

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/622cb6538bdd4700083489d4

😎 Browse the preview: https://deploy-preview-6905--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 12, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 59
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6905--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena changed the title test: improve test coverage test: improve test coverage; properly test core client APIs Mar 12, 2022
@github-actions
Copy link

github-actions bot commented Mar 12, 2022

Size Change: +25 B (0%)

Total Size: 792 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 49.9 kB 0 B
website/build/assets/css/styles.********.css 105 kB 0 B
website/build/assets/js/main.********.js 599 kB +25 B (0%)
website/build/index.html 38.7 kB 0 B

compressed-size-action

@Josh-Cena Josh-Cena merged commit d85cee5 into main Mar 12, 2022
@Josh-Cena Josh-Cena deleted the jc/improve-test branch March 12, 2022 15:15
@slorber
Copy link
Collaborator

slorber commented Mar 16, 2022

thanks, looks nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants