feat(core): SSG worker threads POC #10826
Draft
+139
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: new feature
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: -413 kB (-3.51%) Total Size: 11.4 MB
ℹ️ View Unchanged
|
slorber
added
the
Argos
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: -437 kB (-3.57%) Total Size: 11.8 MB
ℹ️ View Unchanged
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using a thread pool to distribute the SSG load over multiple workers can significantly improve the SSG execution time. According to my local tests (Mac M3 Pro), SSG can be divided by ~2 and probably more if there are enough pathnames to render.
This build benchmark only reports a 15% improvement because SSG is only a part of the full Docusaurus build. The SSG time went from 11s to 5s locally so it remains significant, and will feel even more significant once we activate Rspack persistent caching.
Note: we'll have to fine-tune the thread pool settings, create sensible defaults, and expose an API to customize settings.
Note: This is only a POC used to measure the impact. To merge this, we'll need to do a breaking change, because the Helmet unserializable data structure prevents the usage of worker threads. I removed the Helmet data for this POC, but it is a critical piece for Docusaurus SEO.
Test Plan
CI + dogfood + Argos
Test links
https://deploy-preview-10826--docusaurus-2.netlify.app/
Related issues/PRs
Follow up of #10593
Also the expected next step for Docusaurus Faster: #10556