Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify package manager version in package.json #10807

Merged

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Jan 2, 2025

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Include the packageManager field in package.json to specify the version of Yarn used for the project.
Corepack will use the specified version to ensure consistency across environments.
https://nodejs.org/api/corepack.html

Test Plan

Test links

Deploy preview: https://deploy-preview-10807--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 2, 2025
Copy link

netlify bot commented Jan 2, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit d6b7718
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/677711564346930008a63606
😎 Deploy Preview https://deploy-preview-10807--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 2, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 71 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 53 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 72 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 47 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 65 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 73 🟢 100 🟢 100 🟠 86 Report

@hichemfantar hichemfantar marked this pull request as ready for review January 2, 2025 22:53
@slorber slorber changed the title Specify package manager version in package.json chore: specify package manager version in package.json Jan 3, 2025
@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Jan 3, 2025
@slorber
Copy link
Collaborator

slorber commented Jan 3, 2025

Thanks 👍

I thought I tried this in the past and it was annoying me when not having corepack enabled, but can't reproduce anymore so it must be a mistake I made

@slorber slorber merged commit bdbdd5a into facebook:main Jan 3, 2025
33 of 34 checks passed
@hichemfantar hichemfantar deleted the specify-package-manager-for-corepack branch January 3, 2025 15:39
@hichemfantar
Copy link
Contributor Author

hichemfantar commented Jan 3, 2025

if you currently use corepack, it's probably good for you to know that it looks like there are plans to stop bundling it with node and make it separately installable

nodejs/package-maintenance#606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants