Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(argos): skip screenshot for /tests/pages/react-18 #10656

Merged
merged 1 commit into from
Nov 8, 2024
Merged

test(argos): skip screenshot for /tests/pages/react-18 #10656

merged 1 commit into from
Nov 8, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Nov 8, 2024

Motivation

Argos screenshot fails due to expected console errors

We don't need to screenshot that page anyway

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Nov 8, 2024
@slorber slorber requested a review from Josh-Cena as a code owner November 8, 2024 13:39
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 8, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 8, 2024

✅ [V2]

Name Link
🔨 Latest commit 5c944af
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/672e147e952f7a0008f969bf
😎 Deploy Preview https://deploy-preview-10656--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 76 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 61 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 62 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 49 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 64 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟠 86 Report

@slorber slorber merged commit ae46d11 into main Nov 8, 2024
14 checks passed
@slorber slorber deleted the slorber/argos-escape-react18-url branch November 8, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slorber @facebook-github-bot