-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor team profile components for enhanced readability and added t… #10575
Conversation
…ype safety to the playground file
Hi @artshllk! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but these components are already well-typed and I fail to see how this PR improves any safety.
Nothing, don't mind. I saw some redundant code and created I saw these components don't have tests. Can I make a pull request to test them individually or you think it's not needed? Cheers! |
I don't think that's needed. They are changed less than once a year and we can just visually test them. |
…ype safety to the playground file
Pre-flight checklist
Motivation
The primary motivation behind these changes was to improve the clarity and efficiency of the codebase while leveraging TypeScript's type safety features. This will help prevent potential bugs and facilitate easier collaboration among developers.
Test Plan
Verified that all components render correctly with the updated structure.
Ensured that TypeScript checks pass without any errors or warnings.
Conducted manual testing to confirm that all links and translations function as expected.
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs