Enable disjoint union tests #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
yuxuanchen1997
approved these changes
Oct 22, 2024
|
@yuxuanchen1997 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/redex
that referenced
this pull request
Oct 23, 2024
Summary: ["Files in subdirectories of the tests directory don’t get compiled as separate crates or have sections in the test output."](https://doc.rust-lang.org/book/ch11-03-test-organization.html), so the `test/datatype/disjoint_union_test.rs` test is not run by the rust workflow. These changes move `test/datatype/disjoint_union_test.rs` to `test/disjoint_union_test.rs` and add `#[allow(dead_code)]`s to avoid warnings generated by this test. The rust workflow should show some additional test results: ``` Running `/home/runner/work/SPARTA/SPARTA/rust/target/debug/deps/disjoint_union_test-7d8dce3f7696edda` running 6 tests test test_basic_union_top_bottom_leq ... ok test test_diff_arms_no_leq ... ok test test_join_same_arm ... ok test test_join_diff_arm ... ok test test_meet_diff_arm ... ok test test_meet_same_arm ... ok ``` X-link: facebook/SPARTA#26 Reviewed By: arnaudvenet Differential Revision: D64787297 Pulled By: yuxuanchen1997 fbshipit-source-id: 3175d2a23e9ae34806cafd9c97754709f2ab189c
facebook-github-bot
pushed a commit
to facebook/redex
that referenced
this pull request
Oct 23, 2024
Summary: ["Files in subdirectories of the tests directory don’t get compiled as separate crates or have sections in the test output."](https://doc.rust-lang.org/book/ch11-03-test-organization.html), so the `test/datatype/disjoint_union_test.rs` test is not run by the rust workflow. These changes move `test/datatype/disjoint_union_test.rs` to `test/disjoint_union_test.rs` and add `#[allow(dead_code)]`s to avoid warnings generated by this test. The rust workflow should show some additional test results: ``` Running `/home/runner/work/SPARTA/SPARTA/rust/target/debug/deps/disjoint_union_test-7d8dce3f7696edda` running 6 tests test test_basic_union_top_bottom_leq ... ok test test_diff_arms_no_leq ... ok test test_join_same_arm ... ok test test_join_diff_arm ... ok test test_meet_diff_arm ... ok test test_meet_same_arm ... ok ``` X-link: facebook/SPARTA#26 Reviewed By: arnaudvenet Differential Revision: D64787297 Pulled By: yuxuanchen1997 fbshipit-source-id: 3175d2a23e9ae34806cafd9c97754709f2ab189c
|
@yuxuanchen1997 merged this pull request in ab3d413. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Files in subdirectories of the tests directory don’t get compiled as separate crates or have sections in the test output.", so the
test/datatype/disjoint_union_test.rstest is not run by the rust workflow.These changes move
test/datatype/disjoint_union_test.rstotest/disjoint_union_test.rsand add#[allow(dead_code)]s to avoid warnings generated by this test.The rust workflow should show some additional test results: