Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new scenarios to cve_bydate_ecosystem feature file #659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added new scenarios to cve_bydate_ecosystem feature file #659

wants to merge 2 commits into from

Conversation

cnulenka
Copy link

@cnulenka cnulenka commented Nov 14, 2018 •
edited
Loading

Integration test scenarios for new cve_bydate_ecosystem API endpoint.

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@miteshvp
Copy link
Contributor

[test]

@cnulenka
Copy link
Author

Please merge this PR only after #658 has been merged to master. As this PR contains scenarios for which steps are in #658 PR.

tisnik
tisnik approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as it looks pretty good. TY. Just probably use:

Given...
   And...
When ...
  And...
Then...
  And...

(yeah, I know that we are not consistent in rest of tests... :()

integration-tests/features/cve_bydate_ecosystem.feature Outdated Show resolved Hide resolved
@cnulenka
Fixed minor issues
288e17b 
Fixed issues suggested reviewers.
@cnulenka
Copy link
Author

@tisnik PTAL at updated PR.

@tisnik
Copy link
Member

tisnik commented Nov 15, 2018

[test]

@tisnik
Copy link
Member

tisnik commented Nov 15, 2018

lgtm, please merge after the #658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisnik tisnik tisnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cnulenka @centos-ci @miteshvp @tisnik