-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated FCS to .NET/F# 9.0 + Prepare Fable 5 alpha #3957
Conversation
@MangelMaxime This is just a first pass. We may want to update the Fable CLI to .NET 8.0, now that .NET 6.0 is no longer supported. There are quite a few security warning for old dependencies that need to be updated. Before we merge this, do you mind publishing a new Fable release with all the pending changes that have already been merged? |
Here is perhaps why the Analyzers build fails: dotnet/sdk#44868 Update: Switching the analyzers build to Linux makes it work. |
Hello @ncave, I made a new Fable release with all the changes available on However, to do the release I had to revert Run husky with --allow-roll-forward because I had an error telling me that I didn't investigate any further as I wanted to make the release and we can re-introduce |
That's fine, we can add it later. Just need to figure out how to conditionally add it only for .NET 9.0. |
@MangelMaxime Let me know if you think we need to bump the Fable CLI major version for this change in TFM. |
@ncave Thank you, I will have a look at it tomorrow. |
I think this is ready to be merge but we need to make a decision regarding the version number indeed. I believe we should probably bump the major version because people requesting .NET 6 using If we do the bump, here are the "side effects" we should resolve (perhaps there are some others too):
With all that said I see 2 solutions:
|
@MangelMaxime All good points, I fully agree (especially # 3, I was going to say the same exact thing). |
My two cents: go with a major and publish alpha's until you get it right. |
@MangelMaxime Please go ahead. IMO # 4 (the repl update) can wait until #3960 is merged. |
…llback + Use `FABLE_COMPILER_5` compiler directive
@ncave Fable 5.0.0-alpha.1 has been released. I made the I did it in this order because, I don't see Fable 5 to stay in alpha for a long time and like that we can focus on a single version instead of maintaining 2 versions at the same time. If needed, we can always revisit this position. |
ubuntu-latest