-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Format generated files using ruff #3578
Conversation
@MangelMaxime Any ideas about this? I'm not familiar with the new build system, so perhaps there's something obvious I'm doing wrong? Works locally btw on my mac. https://github.com/fable-compiler/Fable/actions/runs/6703457876/job/18214036253?pr=3578#step:6:52 |
- Install Python tools from the repository root - Invoke ruff from the repository root
…me paths can be missing
@dbrattli It seems like the CI is fixed now. For me the problem seems to be that you were trying to run And you also tried to invoke it from inside the One question that I have is do we still need to have Lines 15 to 16 in 5d309a0
Because of that line, I had to not restore the |
@MangelMaxime Aha, I see, thanks a lot for fixing!! |
No problem, happy to help on what I can. :) |
Use Ruff formatter on the generated Python output files. This makes the generated files easier to read and also makes it easier to spot any issues with the generated code. Ruff format is Black compatible but super fast so it doesn't really add much to the total compile time.