Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Generic typing fixes #3577

Merged
merged 7 commits into from
Oct 31, 2023
Merged

[Python] Generic typing fixes #3577

merged 7 commits into from
Oct 31, 2023

Conversation

dbrattli
Copy link
Collaborator

@dbrattli dbrattli commented Oct 30, 2023 •
edited
Loading

  • Use Any type for all non-repeated generic parameters
  • Don't generate unnecessary type type-vars if generic type is replaced by Any
  • Generate new style _T | None instead of Optional[_T]

@dbrattli dbrattli merged commit 5d309a0 into main Oct 31, 2023
14 checks passed
@dbrattli dbrattli deleted the python-typevar-fixes branch October 31, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MangelMaxime MangelMaxime MangelMaxime left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbrattli @MangelMaxime