Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add applicative test for accessor function shorthand #3572

Merged
merged 6 commits into from
Nov 15, 2023

Conversation

MangelMaxime
Copy link
Member

@MangelMaxime MangelMaxime commented Oct 27, 2023

@dbrattli @ncave

Is it the correct way and place to add these tests?

I was not able to find the RFC, so I don't know if there are others cases to cover.

Edit: The CI is broken because I don't know how to setup .NET 8 on it. Do you know if this is possible to install .NET 8 even if it is still in preview?

When running the tests on my machine, the tests are passing.

@ncave
Copy link
Collaborator

ncave commented Oct 27, 2023

@MangelMaxime

Do you know if this is possible to install .NET 8 even if it is still in preview?

Yes, it's possible, basically download the correct binary, unzip in a folder and set env variable to point to that folder. Something like this:

wget https://download.visualstudio.microsoft.com/download/pr/9144f37e-b370-41ee-a86f-2d2a69251652/bc1d544112ec134184a5aec7f7a1eaf9/dotnet-sdk-8.0.100-rc.2.23502.2-linux-x64.tar.gz

DOTNET_FILE=dotnet-sdk-8.0.100-rc.2.23502.2-linux-x64.tar.gz
export DOTNET_ROOT=$(pwd)/.dotnet

mkdir -p "$DOTNET_ROOT" && tar zxf "$DOTNET_FILE" -C "$DOTNET_ROOT"

export PATH=$PATH:$DOTNET_ROOT

But perhaps we can wait two more weeks for the official .NET 8.0 release and then add those tests, it will be easier to do the CI matrix.

@MangelMaxime
Copy link
Member Author

Let's way for the officiel release of .NET 8.0.

I don't think this is worth the effort to add custom CI rules just to support .NET 8 for 2 weeks.

@MangelMaxime MangelMaxime force-pushed the Accessor_function_shorthand_tests branch from e39a33d to f7ab822 Compare November 15, 2023 19:28
@MangelMaxime MangelMaxime merged commit 6e732ce into main Nov 15, 2023
10 checks passed
@MangelMaxime
Copy link
Member Author

Not all F# 8 features has been added yet, but this is a good start I believe.

@@ -1,6 +1,6 @@
{
"sdk": {
"version": "6.0.100",
"version": "8.0.0",
Copy link
Collaborator

@ncave ncave Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MangelMaxime Should be 8.0.100, no? Fixed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right indeed, I suppose because we have "rollForward": "latestMinor" it didn't break on me.

But better to use a real version

@MangelMaxime MangelMaxime deleted the Accessor_function_shorthand_tests branch March 1, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants