-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update db plugin to require generic abstract db adapter #83
base: develop
Are you sure you want to change the base?
Conversation
Thanks @Caffe1neAdd1ct! I have not worked with Phalcon a while. Would you have time to check the build error in Travis CI? Best |
Hi @fabfuel I'll have a look when time permits, however this will need a Phalcon 4 build which would in turn need a few other build requirements:
Here are my notes from the latest install on arch linux: Download zephir.phar Compile PSR
Compile Zephir Parser
Compile Phalcon
|
Also i've no idea on the Scrutinizer error: https://api.bitbucket.org/1.0/repositories/fabfuel/mongo/tags
Change to
Guessing this is being caused by an out of date version of Composer... they moved from bitbucket api v1 in about v1.8.4 |
So i think the conclusion here is to support Phalcon 4 we to fix the build and upgrade the composer phar being used with a simple |
Great, thanks! I will have a look at the Scrutinizer issue |
I also faced the same issue. The purposed solution by @Caffe1neAdd1ct is correct. @fabfuel Could you please merge it. Thanks |
Phalcon 4 compatibility
Fixes the following error:
TypeError: Argument 2 passed to Fabfuel\Prophiler\Plugin\Phalcon\Db\AdapterPlugin::beforeQuery() must be an instance of Phalcon\Db\Adapter, instance of Phalcon\Db\Adapter\Pdo\Mysql given
Once fixed the toolbar seems to be functioning fine when initialised as follows:
Queries are being logged, request info is available and timeline/memory/etc are being displayed. Not a full compatibility test but seems to be mostly working.