Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] Persistent toggle Toolbar #44

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

lajosbencz
Copy link
Contributor

I really miss the ability to toggle the toolbar... Visible/hidden is stored in a cookie, so it won't reappear after page load.

Here's a working demo: http://static.lazos.me

Having it on the top is also strange (for me at least), but that can be easily fixed with CSS only :]

@@ -2,6 +2,7 @@
@import "compass/css3";
@import "compass/utilities/general/clearfix";

$c-background: #fff;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your demo, the background colors are not aligned. The button's background color is #fff, but the toolbar's is #f8f8f8

@fabfuel
Copy link
Owner

fabfuel commented Sep 28, 2015

Thanks for your pull request! I really like it, but please have a look at the comments.

Best
Fabian

@lajosbencz
Copy link
Contributor Author

Thanks for the feedback Fabian :]
I've changed it according to your comments! I also reverted to the body margin-top placeholder, because the extra div haven't worked out after all... DOM order could be messed up in other projects.

The only thing that still bothers me is the jumpy loading if the toolbar is turned on when the page loads... I tried moving the init code outside document.load with pure JS, but it didn't help either :( Any tips for minimizing that annoying jumpiness? Demo page is still online with the new mods.

@harikt
Copy link

harikt commented Feb 11, 2016

I was browsing to have some sort of hide / show functionality. Probably this is the PR I am looking for.

@sergeyklay
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants