-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFR] Persistent toggle Toolbar #44
base: develop
Are you sure you want to change the base?
Conversation
@@ -2,6 +2,7 @@ | |||
@import "compass/css3"; | |||
@import "compass/utilities/general/clearfix"; | |||
|
|||
$c-background: #fff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your demo, the background colors are not aligned. The button's background color is #fff, but the toolbar's is #f8f8f8
Thanks for your pull request! I really like it, but please have a look at the comments. Best |
Thanks for the feedback Fabian :] The only thing that still bothers me is the jumpy loading if the toolbar is turned on when the page loads... I tried moving the init code outside document.load with pure JS, but it didn't help either :( Any tips for minimizing that annoying jumpiness? Demo page is still online with the new mods. |
I was browsing to have some sort of hide / show functionality. Probably this is the PR I am looking for. |
+1 |
I really miss the ability to toggle the toolbar... Visible/hidden is stored in a cookie, so it won't reappear after page load.
Here's a working demo: http://static.lazos.me
Having it on the top is also strange (for me at least), but that can be easily fixed with CSS only :]