Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(initramfs): accept other media types #17

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

lucido-simon
Copy link
Contributor

We used to only accept the old ManifestV1 response type. However, most images don't come with this manifest type anymore, but instead has a ManifestV2 List / OCI Spec'd manifest.

This PR adds handling of those manifests types:

  • OCI List
  • ManifestV2 List
  • ManifestV2

@lucido-simon lucido-simon force-pushed the feat/initramfs/accept-other-manifests-types branch from 555b3b8 to d522f4d Compare November 21, 2023 12:40
Copy link
Contributor

@alexis-langlet alexis-langlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, I just have a couple of comments

initramfs/src/main.rs Show resolved Hide resolved
initramfs/src/registry.rs Outdated Show resolved Hide resolved
initramfs/src/registry.rs Outdated Show resolved Hide resolved
initramfs/src/registry.rs Outdated Show resolved Hide resolved
@lucido-simon lucido-simon force-pushed the feat/initramfs/accept-other-manifests-types branch from d522f4d to 69055bf Compare December 19, 2023 09:22
Copy link
Contributor

@alexis-langlet alexis-langlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me except for one last small thing.

initramfs/src/registry.rs Outdated Show resolved Hide resolved
We used to only accept the old ManifestV1 response type. However, most
images don't come with this manifest type anymore, but instead has a
ManifestV2 List / OCI Spec'd manifest.

This commit handles those manifests types:
- OCI List
- ManifestV2 List
- ManifestV2

Signed-off-by: Simon LUCIDO <[email protected]>
Signed-off-by: Simon Lucido <[email protected]>
@lucido-simon lucido-simon force-pushed the feat/initramfs/accept-other-manifests-types branch from 69055bf to 8b7c0e9 Compare January 16, 2024 15:39
@lucido-simon lucido-simon merged commit e31e4dd into main Jan 18, 2024
4 checks passed
@lucido-simon lucido-simon deleted the feat/initramfs/accept-other-manifests-types branch January 18, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants