-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(initramfs): accept other media types #17
Merged
lucido-simon
merged 1 commit into
main
from
feat/initramfs/accept-other-manifests-types
Jan 18, 2024
Merged
feat(initramfs): accept other media types #17
lucido-simon
merged 1 commit into
main
from
feat/initramfs/accept-other-manifests-types
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucido-simon
force-pushed
the
feat/initramfs/accept-other-manifests-types
branch
from
November 21, 2023 12:40
555b3b8
to
d522f4d
Compare
alexis-langlet
requested changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, I just have a couple of comments
lucido-simon
force-pushed
the
feat/initramfs/accept-other-manifests-types
branch
from
December 19, 2023 09:22
d522f4d
to
69055bf
Compare
alexis-langlet
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to me except for one last small thing.
We used to only accept the old ManifestV1 response type. However, most images don't come with this manifest type anymore, but instead has a ManifestV2 List / OCI Spec'd manifest. This commit handles those manifests types: - OCI List - ManifestV2 List - ManifestV2 Signed-off-by: Simon LUCIDO <[email protected]> Signed-off-by: Simon Lucido <[email protected]>
lucido-simon
force-pushed
the
feat/initramfs/accept-other-manifests-types
branch
from
January 16, 2024 15:39
69055bf
to
8b7c0e9
Compare
alexis-langlet
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to only accept the old ManifestV1 response type. However, most images don't come with this manifest type anymore, but instead has a ManifestV2 List / OCI Spec'd manifest.
This PR adds handling of those manifests types: