Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cgroup V2 statistic engine improvements #68

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

gkhandake
Copy link
Contributor

  • Improve statistic engine to support cgroup v2 memory stats

@gkhandake gkhandake marked this pull request as ready for review November 24, 2024 11:21
@gkhandake
Copy link
Contributor Author

Hi @f18m please review and suggest. This change was needed to put few assertions and check on memory utilization.

@f18m
Copy link
Owner

f18m commented Nov 25, 2024

@gkhandake can you merge from main?
I was not sure about the changes to the Dockerfile.builder, so I had a look and I found my own docker pattern to be quite weird (with the dockerfile being split in a builder and non-builder part... for such a small app). So I corrected the thing and restored a more standard approach to docker image building.
If you merge from main, you can see if you can build the docker image without the need to change the Alpine pkgs being installed... thanks

@gkhandake
Copy link
Contributor Author

gkhandake commented Nov 26, 2024

Done

@gkhandake gkhandake closed this Nov 26, 2024
@gkhandake gkhandake reopened this Nov 26, 2024
@f18m
Copy link
Owner

f18m commented Nov 26, 2024

Done

thanks! merging now!

@f18m f18m merged commit b3a0668 into f18m:master Nov 26, 2024
6 checks passed
@gkhandake
Copy link
Contributor Author

Hi @f18m can we please also get a release with minor version bump ?

@f18m
Copy link
Owner

f18m commented Nov 27, 2024

Hi @f18m can we please also get a release with minor version bump ?

Sure, let me spin a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants