Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-27299: search index not updated if obje… #1293

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bernhard-roessler
Copy link

Ticket: https://jira.ez.no/browse/EZP-27299
Search index is not updated if a object is hidden by the cronjob (hide.php).

@gggeek
Copy link
Contributor

gggeek commented Apr 25, 2017

Any reason why the standard hide operation would not work in this scenario? Maybe there is a bug somewhere to be fixed instead of adding this workaround ?

@siegfried-zach
Copy link

What do you mean with "standard hide operation"?
I assume the "eZContentObjectTreeNode::hideSubTree( $node );" is already a standard operation. In our cases it did not register the object for reindexing. Maybe there is a better place to put this change, but for us it was the "nearest" one :-)

@c-revillo
Copy link

maybe @gggeek is talking about this one? https://github.com/ezsystems/ezpublish-legacy/blob/master/kernel/classes/ezcontentobjecttreenode.php#L5983
Looking there https://github.com/ezsystems/ezpublish-legacy/blob/master/kernel/classes/ezcontentobjecttreenode.php#L6020 i don't know if that op does a reindex of the content, but if not, maybe the code you added can be moved here...

@yannickroger yannickroger changed the title https://jira.ez.no/browse/EZP-27299: search index not updated if obje… EZP-27299: search index not updated if obje… Apr 26, 2017
@andrerom
Copy link
Contributor

andrerom commented Apr 29, 2017

And this is the problem with (missing) layers in legacy.. For the most part use of eZSearch is done outside of persistence classes, like for instance in operations classes: https://github.com/ezsystems/ezpublish-legacy/blob/master/kernel/content/ezcontentoperationcollection.php#L1011

@pkamps
Copy link
Contributor

pkamps commented May 17, 2017

I agree. The search index update should happen in https://github.com/ezsystems/ezpublish-legacy/blob/master/kernel/content/ezcontentoperationcollection.php.

Bernhard, would the function changeHideStatus work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants