Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx wrong path creation in css pack #1230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alexnder
Copy link

If you have several files of one font, for ex.: url(fonts/font.woff) url(fonts/font.woff2)
It's pack to this:

url(/design/siteaccess/stylesheets/fonts/font.woff)
url(/design/siteaccess/stylesheets//design/siteaccess/stylesheets/fonts/font.woff2)

The commit fix this bug.

If you have several files of one font, for ex.: `url(fonts/font.woff)` `url(fonts/font.woff2)`
It's pack to this:
```
url(/design/siteaccess/stylesheets/fonts/font.woff)
url(/design/siteaccess/stylesheets//design/siteaccess/stylesheets/fonts/font.woff2)
```

The commit fix this bug.
@andrerom
Copy link
Contributor

andrerom commented Jan 6, 2016

+0,5 as we don't have any unit tests here so a full +1 will need a bit more testing from community (one alternative is that we merge and await backports until the patch has been in circulation for some months to await possible feedback)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants