Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed distribution link forcing https redirection #248

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Steveb-p
Copy link
Contributor

Question Answer
JIRA issue CI issue
Type improvement
Target Ibexa version v3.3
BC breaks no

Fixed links in installation script to use https, instead of http.

Another option is to also add -L option to curl call, making the installation follow any redirects. I opted to not do that, so that we would have broken tests when links change (if).

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping for example @ibexa/php-dev for back-end changes and/or @ibexa/javascript-dev for front-end changes).

@Steveb-p Steveb-p requested a review from a team March 26, 2024 10:50
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@konradoboza konradoboza requested a review from a team March 26, 2024 10:51
@Steveb-p Steveb-p merged commit 6ddce40 into 3.3 Mar 26, 2024
19 checks passed
@Steveb-p Steveb-p deleted the fix-dist-link-broken branch March 26, 2024 11:14
alongosz added a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants