IBX-7485: Skipped files with corrupted filenames when loading and deleting #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barw4
changed the title
6 tasks
alongosz
reviewed
Jan 19, 2024
There was a problem hiding this comment.
+1 to this over #399 but please work on integration coverage for this case.
Paths stored in the database can be corrupted by performing a query directly on a current connection. Every integration test case contains getDatabaseConnection() method.
alongosz
reviewed
Jan 30, 2024
eZ/Publish/API/Repository/Tests/FieldType/ImageIntegrationTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/API/Repository/Tests/FieldType/ImageIntegrationTest.php
Outdated
Show resolved
Hide resolved
|
alongosz
approved these changes
Jan 30, 2024
ViniTou
approved these changes
Jan 30, 2024
Steveb-p
reviewed
Jan 30, 2024
|
|
||
| $contentService->deleteContent($content->getVersionInfo()->getContentInfo()); | ||
|
|
||
| // Expect no League\Flysystem\CorruptedPathDetected thrown |
There was a problem hiding this comment.
Assert no assertions are made here (unless I'm mistaken?).
There was a problem hiding this comment.
Assert no assertions are made here (unless I'm mistaken?).
Either there are some implicit assertions performed in the background or we don't have strict config. We'll see how it behaves on a merge up.
tomaszszopinski
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept PR
v3.3This PR try/catches the
CorruptedPathDetectedexception originating from theflysystem/leaguepackage. Files will be treated as missing.Another idea (Filesystem override #399):
Checklist:
$ composer fix-cs).@ezsystems/engineering-team).