IBX-7954: Applied review remark

ezsystems · Mar 18, 2024 · d776834 · d776834
1 parent fd71c45
commit d776834
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js b/src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js
@@ -98,6 +98,18 @@
                 return field.fieldDefinitionIdentifier === imageAssetMapping['contentFieldIdentifier'];
             });
 
+            if (imageField.fieldValue === null) {
+                showErrorNotification(
+                    Translator.trans(
+                        /* @Desc("The chosen asset has no image data available.") */ 'ezimageasset.empty_data.message.error',
+                        {},
+                        'fieldtypes_preview'
+                    )
+                );
+
+                return;
+            }
+
             this.updateData(
                 response.ContentInfo.Content._id,
                 response.ContentInfo.Content.TranslatedName,
@@ -126,18 +138,6 @@
          * @param {Object} image
          */
         updateData(destinationContentId, destinationContentName, destinationLocationId, image) {
-            if (image === null) {
-                showErrorNotification(
-                    Translator.trans(
-                        /* @Desc("The chosen asset has no image data available.") */ 'ezimageasset.empty_data.message.error',
-                        {},
-                        'fieldtypes_preview'
-                    )
-                );
-
-                return;
-            }
-
             const preview = this.fieldContainer.querySelector('.ez-field-edit__preview');
             const previewVisual = preview.querySelector('.ez-field-edit-preview__visual');
             const previewImg = preview.querySelector('.ez-field-edit-preview__media');