Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eZ Find suggestion #182

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

eZ Find suggestion #182

wants to merge 3 commits into from

Conversation

xrow
Copy link
Contributor

@xrow xrow commented Nov 21, 2014

No description provided.

@lolautruche
Copy link
Contributor

Hi and thanks @xrow

Can you please create an issue on Jira and describe what you're contributing?

Ping @andrerom @paulborgermans @bdunogier @yannickroger

@xrow
Copy link
Contributor Author

xrow commented Nov 21, 2014

@andrerom
Copy link
Contributor

ping @paulborgermans

@paulborgermans
Copy link
Contributor

-1:
for loc field type, there is no schema.xml counterpart (otherwise would be ok)
locale conversion should be done before its submitted to the ezfind api

@xrow
Copy link
Contributor Author

xrow commented Nov 22, 2014

2,5 is a valid php float. Conversion needs to happen exactly there. PHP isn't like other languages unfortunatelly.
http://php.net/manual/de/language.types.float.php#58824
I try to attach the schema.

@paulborgermans
Copy link
Contributor

  • location type feature: schema still wrong
  • formatting and locales: when using a non default (C) locale, other numeric output (int, maybe custom datatypes) will also cause problems, so patch is anyhow incomplete

@xrow
Copy link
Contributor Author

xrow commented Nov 27, 2014

I see your point with the locale. Unfortuatelly this means somewhere in the installation setlocale isn`t properly used. I investigate on that one. Can you point out what is wrong with the schema?

@paulborgermans
Copy link
Contributor

On having more robustness towards any other locale, see this gist: https://gist.github.com/paulborgermans/0d10f4d99f3fb0a7a3c8

location in schema on the other hand: 4 underscores instead of 3 in the new dynamic fields added, and also the fieldtype for location is missing

hth
Paul

@yannickroger
Copy link
Contributor

@xrow Issue closed as you requested, can you close this pull request ?

@xrow
Copy link
Contributor Author

xrow commented Nov 28, 2014

The pull request yet has this feature, but I can live without it since we patch the sources anyway. Up to you.

@xrow
Copy link
Contributor Author

xrow commented Nov 28, 2014

Hi,

implementing a different naming for the dynamic field is too much work on our end. Lets forget the feature request and lets close the pull. In addition I would very much prefer the patch (https://gist.github.com/paulborgermans/0d10f4d99f3fb0a7a3c8 ) that @paulborgermans is proposing, but I would need it in 5.4 branch.

@yannickroger
Copy link
Contributor

ping @andrerom regarding @paulborgermans patch

@andrerom
Copy link
Contributor

@yannickroger

HTTP/1.1 501 Not Implemented
Date: Sun, 30 Nov 2014 21:07:25 CET
Connection: close

@yannickroger
Copy link
Contributor

so should we close this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants