New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/case when fk is pointer #38

Merged

eyo-chen merged 3 commits into main from fix/case-when-fk-is-pointer

Sep 21, 2024

Owner

eyo-chen commented Sep 20, 2024

fix the case when foreign key is pointer

Eyo Chen added 3 commits

September 21, 2024 07:50


          fix: avoid error when fk is pointer

a67e967


          test: handle new test case

e185a9c


          refactor: remove unnecessary condition

90ce51b

eyo-chen commented

View reviewed changes

helpers.go

Comment on lines 342 to 344

-              		if target.IsNil() {
-              			target.Set(reflect.New(target.Type().Elem()))
-              		}

Owner Author

eyo-chen Sep 21, 2024

this condition is unnecessary because all the field will be set with non-zero value by setAssValue

eyo-chen merged commit 819105d into main

3 checks passed

eyo-chen deleted the fix/case-when-fk-is-pointer branch

September 21, 2024 00:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet