Make the attention mask a mandatory argument of models #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is very easy to forget to pass the attention mask, giving bad output. On the other hand it is very unlikely that someone doesn't want to use an attention mask. In such cases, it is always possible to create a custom mask all elements set to `True`. While at it, also consistently make `piece_ids`/`attention_mask` positional arguments, while making all other arguments kwarg-only.
danieldk
added
feat/model
Co-authored-by: Madeesh Kannan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is very easy to forget to pass the attention mask, giving bad output.
On the other hand it is very unlikely that someone doesn't want to use
an attention mask. In such cases, it is always possible to create a
custom mask all elements set to
True.While at it, also consistently make
piece_ids/attention_maskpositional arguments, while making all other arguments kwarg-only.
Types of change
Checklist