Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added from_url method to fetch evaluation annotation from the api. #1795

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ganeshrvel
Copy link

Added from_url method to fetch evaluation annotation from the api.
Made some optimizations.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 26, 2024
renamed the fn from_url to from_ragas_platform
return cls._process_dataset(dataset, metric_name)

@classmethod
def from_ragas_platform(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this brings to the point about what we are calling the thing at app.ragas.io - IMO is should be Ragas App and so the method should be from_ragas_app

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from_app is what I have named it right now, in case we need to be explicit, lets call it from_ragas_app

improve error handling in api responses with debug info
enhance metric training with multiple data sources including run_id
renamed the from_ragas_platform to from_app
Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the ci by running make run-ci and all looks good. Will discuss the change of docs later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants