Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't warn when context_precision is correctly called #168

Merged

Conversation

monstertruck
Copy link
Contributor

I'm not sure when 0.1.0 is scheduled for release, but in the meantime, when context_precision is (correctly) called, you still get a deprecation warning because of what I think is a typo.

Before change:
image

After change:
image

@monstertruck
Copy link
Contributor Author

I'm not sure when 0.1.0 is scheduled for release, but in the meantime, when context_precision is (correctly) called, you still get a deprecation warning because of what I think is a typo.

Before change: image

After change: image

(make run-ci --> 👍 )

@jjmachan
Copy link
Member

jjmachan commented Oct 6, 2023

thank you so much @monstertruck for catching this bug and fixing this :)

@jjmachan jjmachan merged commit 2a41255 into explodinggradients:main Oct 6, 2023
14 checks passed
@jjmachan
Copy link
Member

Hey @monstertruck
Thank you so much for helping us improve ragas with your PR ❤️
Now since it's Christmas and all we wanted to send you a postcard and a couple of stickers as our way of saying thank you for your contribution. If you are interested could you shoot an email at [email protected] and I'll tell you more?

Cheers 🙂
Jithin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants