Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalizing MITgcm read in to enabele read in of SPARC #60

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

AaronDavidSchneider
Copy link
Contributor

@AaronDavidSchneider AaronDavidSchneider commented Nov 17, 2023

Topic:

This PR tracks the changes that were performed to make gcmt ready for SPARC/MITgcm.
Thank you for your comments and help Vivien Parmentier and Nishil Mehta.

Improvements:

  • atm_p0 is the reference pressure for Theta in MITgcm and is now used as such
  • Rs can be defaulted to atm_kappa * atm_cp, where the default of atm_kappa is 2/7. This logic is now implemented.
  • rename readin to mitgcm_readin
  • proper renaming of variable names from cubedsphere names to gcmt names to be less dependend on cubedsphere.

Todo:

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #60 (614c8e1) into main (47e33a6) will increase coverage by 0.28%.
Report is 1 commits behind head on main.
The diff coverage is 91.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   78.30%   78.58%   +0.28%     
==========================================
  Files          14       14              
  Lines        1549     1560      +11     
==========================================
+ Hits         1213     1226      +13     
+ Misses        336      334       -2     
Flag Coverage Δ
unittests 78.58% <91.52%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gcm_toolkit/core/const.py 100.00% <ø> (ø)
gcm_toolkit/core/units.py 100.00% <100.00%> (ø)
gcm_toolkit/mitgcm/__init__.py 100.00% <ø> (ø)
gcm_toolkit/utils/read_and_write.py 95.09% <100.00%> (ø)
gcm_toolkit/mitgcm/utils.py 94.11% <96.66%> (ø)
gcm_toolkit/mitgcm/read_in.py 94.00% <94.00%> (ø)
gcm_toolkit/utils/manipulations.py 91.39% <81.25%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant