Fixes to python test environment #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 78.30% 78.30%
=======================================
Files 14 14
Lines 1549 1549
=======================================
Hits 1213 1213
Misses 336 336
Flags with carried forward coverage won't be shown. Click here to find out more. |
Comment on lines
-46
to
+60
| dsi_clouds = tools.get_models('0') | ||
| tmp = np.ones((len(dsi_clouds['time']), len(dsi_clouds['lat']), | ||
| len(dsi_clouds['lon']), len(dsi_clouds['Z_l']))) | ||
| dsi_clouds['ClAb'] = (('time', 'lat', 'lon', 'Z_l'), tmp*1e-5) | ||
| dsi_clouds['ClDs'] = (('time', 'lat', 'lon', 'Z_l'), tmp*1e2) | ||
| dsi_clouds['ClDr'] = (('time', 'lat', 'lon', 'Z_l'), tmp*1e3) | ||
| dsi_clouds['ClVf_Test1[s]'] = (('time', 'lat', 'lon', 'Z_l'), tmp*0.5) | ||
| dsi_clouds['ClVf_Test2[s]'] = (('time', 'lat', 'lon', 'Z_l'), tmp*0.5) | ||
| tools._replace_model('0', dsi_clouds) | ||
| dsi_clouds = tools.get_models("0") | ||
| tmp = np.ones( | ||
| ( | ||
| len(dsi_clouds["time"]), | ||
| len(dsi_clouds["lat"]), | ||
| len(dsi_clouds["lon"]), | ||
| len(dsi_clouds["Z"]), | ||
| ) | ||
| ) | ||
| dsi_clouds["ClAb"] = (("time", "lat", "lon", "Z"), tmp * 1e-5) | ||
| dsi_clouds["ClDs"] = (("time", "lat", "lon", "Z"), tmp * 1e2) | ||
| dsi_clouds["ClDr"] = (("time", "lat", "lon", "Z"), tmp * 1e3) | ||
| dsi_clouds["ClVf_Test1[s]"] = (("time", "lat", "lon", "Z"), tmp * 0.5) | ||
| dsi_clouds["ClVf_Test2[s]"] = (("time", "lat", "lon", "Z"), tmp * 0.5) | ||
| tools._replace_model("0", dsi_clouds) |
There was a problem hiding this comment.
@Kiefersv, could you comment on these changes I had to make? I think the Z_l here is strange?!
There was a problem hiding this comment.
I double checked and you are indeed right that it should be Z. No idea why it worked before with Z_l. Did this cause the problems?
There was a problem hiding this comment.
No. Its likely problems related to xarray's master branch. But this looked odd to me.
Kiefersv
approved these changes
Oct 27, 2023
Kiefersv
reviewed
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.