Fixed crop quality_chance calculation #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the Crop.cs source file, the crop quality is determined by first comparing a random double between 0.0 and 1.0 to see if it is less than the gold_chance. If it is not, it then compares a new random double between 0.0 and 1.0 to see if it is less than the silver_chance. Due to how the nested if statements are set up, you need to multiply the silver_chance number by the chance that the crop was not gold. Then the base chance is just 1-(gold_chance + silver_chance).
JeffreyBytes
added a commit
to JeffreyBytes/crop_planner
that referenced
this pull request
Apr 6, 2022
big thanks to zorvex09 for the fix: exnil#17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the Crop.cs source file, the crop quality is determined by first comparing a random double between 0.0 and 1.0 to see if it is less than the gold_chance. If it is not, it then compares a new random double between 0.0 and 1.0 to see if it is less than the silver_chance. Due to how the nested if statements are set up, you need to multiply the silver_chance number by the chance that the crop was not gold. Then the base chance is just 1-(gold_chance + silver_chance).