Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#990: Forward jar options without changing order #467

Closed

Conversation

tomuben
Copy link
Collaborator

@tomuben tomuben commented Oct 22, 2024

@tomuben tomuben self-assigned this Oct 23, 2024
@tomuben tomuben added the refactoring Code improvement without behavior change label Oct 23, 2024
@tomuben tomuben changed the title #990: Support escape sequence for ending white spaces in JAR option #990: Forward jar options as is Oct 23, 2024
1. Splitted up Converter into Legacy and V2
2. Splitted up Extractor into Interface and Implementation
3. JavaContainerBuilder now instantiates Extractor instead of parser.
1. Use std::vector for collecting JARs in converter v2
2. Implemented StringOps::removeQuotesSafely() + tests
3. Use StringOps::removeQuotesSafely() for JARs
Comment on lines +39 to +47
std::make_pair("string", "string"),
std::make_pair("\"string", "\"string"),
std::make_pair("\"string\"", "string"),
std::make_pair("\"string'", "\"string'"),
std::make_pair("'string'", "string"),
std::make_pair("' string '", " string "),
std::make_pair("' ' string '", " ' string "),
std::make_pair(" ' ' string '", " ' string "),
std::make_pair(" aaa ' ' string '", " aaa ' ' string '"),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check if we need more test cases....

@tomuben tomuben changed the title #990: Forward jar options as is #990: Forward jar options without changing order Oct 23, 2024
@tomuben tomuben closed this Oct 24, 2024
@tomuben tomuben deleted the refactoring/990_support_escape_seq_whitespace_jar_option branch October 28, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant