#989: Trim script class and import script options #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomuben
commented
Oct 21, 2024
Comment on lines
15
to
32
| inline void ltrim(std::string &s) { | ||
| s.erase(s.begin(), std::find_if(s.begin(), s.end(), [](unsigned char ch) { | ||
| return !std::isspace(ch); | ||
| })); | ||
| } | ||
|
|
||
|
|
||
| inline void rtrim(std::string &s) { | ||
| s.erase(std::find_if(s.rbegin(), s.rend(), [](unsigned char ch) { | ||
| return !std::isspace(ch); | ||
| }).base(), s.end()); | ||
| } | ||
|
|
||
| inline void trim(std::string &s) { | ||
| ltrim(s); | ||
| rtrim(s); | ||
| } |
There was a problem hiding this comment.
Copied from https://stackoverflow.com/a/217605
There was a problem hiding this comment.
Please add the link as comment
tomuben
force-pushed
the
bug/989_trim_scriptclass_and_import_script_options
branch
from
235772a to
1691e48
Compare
tkilias
reviewed
Oct 22, 2024
| @@ -156,6 +199,47 @@ TEST(JavaContainer, simple_import_script) { | |||
| EXPECT_EQ(vm.getJavaVMInternalStatus().m_jvmOptions, expectedJVMOptions); | |||
| } | |||
|
|
|||
| TEST(JavaContainer, simple_import_script_with_white_space) { | |||
There was a problem hiding this comment.
does it make sense also to add a test with a quoted import script, because it is legal
…n order to avoid memory leak if exception in SWIGVMContainers::JavaVMImpl::JavaVMImpl() occurs.
tomuben
force-pushed
the
bug/989_trim_scriptclass_and_import_script_options
branch
from
2adeb77 to
f552241
Compare
tkilias
approved these changes
Oct 22, 2024
tomuben
deleted the
bug/989_trim_scriptclass_and_import_script_options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to exasol/script-languages-release#989