#969: Use new CTPG parser in java vm #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomuben
force-pushed
the
refactoring/967_add_ctpg_script_options_parser
branch
from
f156bf4 to
cc7e7d1
Compare
Base automatically changed from
refactoring/967_add_ctpg_script_options_parser
to
master
October 9, 2024 15:16
tomuben
force-pushed
the
refactoring/969_use_new_ctpg_parser_in_java_vm
branch
from
2b0ba44 to
77e9955
Compare
tomuben
commented
Oct 10, 2024
tkilias
reviewed
Oct 11, 2024
| std::make_pair("\\f-Dhttp.agent=ABCDEF", "-Dhttp.agent=ABCDEF"), | ||
| std::make_pair("\\v-Dhttp.agent=ABCDEF", "-Dhttp.agent=ABCDEF") | ||
| }; | ||
|
|
There was a problem hiding this comment.
Do we have a test for escaped whitespace in the middle of a option, because this was one of the cases that was as bug reported
-Dhttp.agent=ABC\ DEF;
This is less of an option line parser issue then an issue of the value handling of the Jvm options splitter
There was a problem hiding this comment.
This bug is not fixed yet.
My plan was to fix exasol/script-languages-release#878 in another PR, in order to keep a clean git history.
In the scope of #878 I will extend the test here.
tkilias
reviewed
Oct 11, 2024
tkilias
reviewed
Oct 11, 2024
tkilias
reviewed
Oct 11, 2024
tkilias
reviewed
Oct 11, 2024
tkilias
reviewed
Oct 11, 2024
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.cc
Show resolved
Hide resolved
tkilias
reviewed
Oct 11, 2024
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.cc
Show resolved
Hide resolved
tkilias
reviewed
Oct 11, 2024
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.cc
Show resolved
Hide resolved
tkilias
reviewed
Oct 11, 2024
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.cc
Show resolved
Hide resolved
tkilias
reviewed
Oct 11, 2024
Parse only lines which contain a '%'.
tkilias
reviewed
Oct 15, 2024
tkilias
reviewed
Oct 15, 2024
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.cc
Outdated
Show resolved
Hide resolved
…ipt_importer.cc Co-authored-by: Torsten Kilias <[email protected]>
Background: Tests need to run under Ubuntu 24.04 or later (because of ASAN). installUdfClientDeps.sh is tested only on Ubuntu 22.04.
tkilias
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to exasol/script-languages-release#969
Please note: The unit tests at https://github.com/exasol/script-languages/blob/master/exaudfclient/base/javacontainer/test/cpp/javacontainer_test.cc are being re-used to test identical behavior of both parser: The old (named legacy) parser, and the new (based on CTPG) parser.