Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Java and standard tests #425

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

tomuben
Copy link
Collaborator

@tomuben tomuben commented Jun 6, 2024

No description provided.

@@ -115,7 +123,8 @@ def add_containers_to_hosts_file_in_docker_db(self, env):
def upload_hadoop_etl_udf_jar_to_bucket_fs(self, env):
docker_db_container = env.get_docker_db_container()
docker_db_ip = env.get_ip_address_of_container(docker_db_container)
upload_url = "http://{docker_db_ip}:6583/myudfs/hadoop-etl-udfs-v0.0.1-apache-2.8.5-3.0.0.jar".format(
bucketfs_port = bucket_fs_port_from_environment_info_file()
upload_url = f"http://{docker_db_ip}:{bucketfs_port}/myudfs/hadoop-etl-udfs-v0.0.1-apache-2.8.5-3.0.0.jar".format(
docker_db_ip=docker_db_ip)
username = "w"
password = "write" # TOOD hardcoded
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we replace the copies, we should also replace the hard coded credentials and the docker_db_ip

def upload_to_bucketfs(self, path: Path) -> str:
docker_db_container = self.env.get_docker_db_container()
docker_db_ip = self.env.get_ip_address_of_container(docker_db_container)
upload_url = f"http://{docker_db_ip}:2580/myudfs/{path.name}"
bucketfs_port = bucket_fs_port_from_environment_info_file()
upload_url = f"http://{docker_db_ip}:{bucketfs_port}/myudfs/{path.name}"
username = "w"
password = "write"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class WebsocketAPIConnectionTest(udf.TestCase):
# TODO use dsn and credentials injected into the testcase
connection = "localhost:8888"
db_port = db_port_from_environment_info_file()
connection = f"localhost:{db_port}"
user = "sys"
pwd = "exasol"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we replace the copies, we should also replace the hard coded credentials

host = "localhost"
port = "8888"
port = str(db_port)
user = "sys"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we replace the copies, we should also replace the hard coded credentials

class WebsocketAPIConnectionTest(udf.TestCase):
connection = "localhost:8888"
db_port = db_port_from_environment_info_file()
connection = f"localhost:{db_port}"
user = "sys"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we replace the copies, we should also replace the hard coded credentials

@tomuben tomuben merged commit 223040a into master Jun 7, 2024
10 checks passed
@tomuben tomuben deleted the bug/fixed_java_and_standard_tests branch June 7, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants