Skip to content

Commit

Permalink
#26:Using host network for execution of exasclt
Browse files Browse the repository at this point in the history
In case of exasclt upload the user might try to push image to a custom network path. For that we need to execute the exasclt docker instance in the host network, not the isolated docker network.

Also, execute tests within container, by using exaslct script instead of starter_scripts/exaslct_without_poetry.sh
  • Loading branch information
tomuben committed Jun 8, 2021
1 parent dfbc392 commit fdd5744
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
9722441cc606dbd5eb9672269404947169b9b3155181b2cb40a52d8647d5e4918b20fbfb845ed4b36f3aee4eb83449d2b112915656001d9fbe3bb9bc7fce9f91 exaslct_within_docker_container.sh
7c284ad60bc93a6611d1e31ce21c8fc5a293b2278bbaef6feaf2c9b618d4d719132fc10a092e8990134795360ac764c83f269104b50d2cd2ee5a184bd1b22317 exaslct_within_docker_container.sh
2 changes: 1 addition & 1 deletion starter_scripts/exaslct_within_docker_container.sh
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,6 @@ tmpfile_env=$(mktemp)
trap 'rm -f -- "$tmpfile_env"' INT TERM HUP EXIT

create_env_file_debug_protected "$tmpfile_env"
docker run --env-file "$tmpfile_env" --rm $terminal_parameter -v "$PWD:$PWD" -v "$DOCKER_SOCKET_MOUNT" -w "$PWD" ${mount_point_parameter[@]} "$RUNNER_IMAGE_NAME" bash -c "$RUN_COMMAND"
docker run --network host --env-file "$tmpfile_env" --rm $terminal_parameter -v "$PWD:$PWD" -v "$DOCKER_SOCKET_MOUNT" -w "$PWD" ${mount_point_parameter[@]} "$RUNNER_IMAGE_NAME" bash -c "$RUN_COMMAND"

umask "$old_umask"
2 changes: 1 addition & 1 deletion test/utils.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from pathlib import Path

EXASLCT_DEFAULT_BIN = Path(Path(__file__).parent.parent, "starter_scripts/exaslct_without_poetry.sh")
EXASLCT_DEFAULT_BIN = Path(Path(__file__).parent.parent, "exaslct")

0 comments on commit fdd5744

Please sign in to comment.