Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#8 add ci task to check if the generated api is outdated #12

Merged
merged 13 commits into from
Apr 19, 2024
Merged

Feature/#8 add ci task to check if the generated api is outdated #12

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6bc23d2
Added nox task to check if API is outdated
ckunki Apr 19, 2024
bedccb3
Added GitHub workflow file
ckunki Apr 19, 2024
32a6aaf
Generated API
ckunki Apr 19, 2024
8196fe2
Formatted developer_guide
ckunki Apr 19, 2024
a1d7d50
Updated README
ckunki Apr 19, 2024
9b71a82
Apply suggestions from code review
ckunki Apr 19, 2024
764ee09
Added reporting to slack channel
ckunki Apr 19, 2024
cd34a84
Rephrased monitoring message
ckunki Apr 19, 2024
d66b28d
Run silently only locally, but not in CI
ckunki Apr 19, 2024
d0eddc3
Execute workflow check-api-outdated also for PRs
ckunki Apr 19, 2024
1a70502
Update noxfile.py
ckunki Apr 19, 2024
c712c6d
Updated triggers for workflow check-api-outdated
ckunki Apr 19, 2024
a334a17
re-added pull_request activity type with comment
ckunki Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/check-api-outdated.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
name: Check if OpenAPI is Outdated

on:
push:
branches-ignore:
- "github-pages/*"
- "gh-pages/*"
- "main"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why shouldn't it run on main

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the code from ci.yml which was generated by PTB.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the intention is to run checks only once (on the branch) but not another time (after merging).

- "master"
pull_request:
types: [opened, reopened]
ckunki marked this conversation as resolved.
Show resolved Hide resolved
workflow_dispatch:
schedule:
# “At 4 am on every day.” (https://crontab.guru)
Expand Down
Loading